MKS Base 1.2 compile error

Hey guys, I am having my real first lesson in compiling in Arduino for my MKS base 1.2, I have tried and tried replicating some of the code from another configuration.h file.

this is the error I get.

Thanks for any help

Arduino: 1.6.3 (Windows 7), Board: "Arduino Mega or Mega 2560, ATmega2560 (Mega 2560)"

In file included from Marlin.h:22:0,

from temperature.cpp:32:

temperature.cpp: In function 'void PID_autotune(float, int, int)':

Configuration.h:147:26: error: expected ')' before numeric constant

#define PID_MAX BANG_MAX 256 // limits current to nozzle while PID is active (see PID_FUNCTIONAL_RANGE below); 255=full current

^

temperature.cpp:217:28: note: in expansion of macro 'PID_MAX'

soft_pwm[extruder] = (PID_MAX)/2;

^

Configuration.h:147:26: error: expected ')' before numeric constant

#define PID_MAX BANG_MAX 256 // limits current to nozzle while PID is active (see PID_FUNCTIONAL_RANGE below); 255=full current

^

temperature.cpp:218:18: note: in expansion of macro 'PID_MAX'

bias = d = (PID_MAX)/2;

^

In file included from Marlin.h:30:0,

from temperature.cpp:32:

Configuration.h:147:26: error: expected ')' before numeric constant

#define PID_MAX BANG_MAX 256 // limits current to nozzle while PID is active (see PID_FUNCTIONAL_RANGE below); 255=full current

^

C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino/Arduino.h:87:60: note: in definition of macro 'constrain'

#define constrain(amt,low,high) ((amt)<(low)?(low)(amt)>(high)?(high)amt)))

^

temperature.cpp:262:69: note: in expansion of macro 'PID_MAX'

bias = constrain(bias, 20 ,(extruder<0?(MAX_BED_POWER)PID_MAX))-20);

^

temperature.cpp:262:82: error: expected ')' before ';' token

bias = constrain(bias, 20 ,(extruder<0?(MAX_BED_POWER)PID_MAX))-20);

^

temperature.cpp:262:82: error: expected ')' before ';' token

temperature.cpp:262:82: error: expected ')' before ';' token

temperature.cpp:262:82: error: expected ')' before ';' token

In file included from Marlin.h:22:0,

from temperature.cpp:32:

Configuration.h:147:26: error: expected ')' before numeric constant

#define PID_MAX BANG_MAX 256 // limits current to nozzle while PID is active (see PID_FUNCTIONAL_RANGE below); 255=full current

^

temperature.cpp:263:52: note: in expansion of macro 'PID_MAX'

if(bias > (extruder<0?(MAX_BED_POWER)PID_MAX))/2) d = (extruder<0?(MAX_BED_POWER)PID_MAX)) - 1 - bias;

^

temperature.cpp:263:118: error: expected ')' before ';' token

if(bias > (extruder<0?(MAX_BED_POWER)PID_MAX))/2) d = (extruder<0?(MAX_BED_POWER)PID_MAX)) - 1 - bias;

^

temperature.cpp:263:118: error: expected ')' before ';' token

In file included from Marlin.h:22:0,

from temperature.cpp:32:

temperature.cpp: In function 'void updatePID()':

Configuration.h:147:26: error: expected ';' before numeric constant

#define PID_MAX BANG_MAX 256 // limits current to nozzle while PID is active (see PID_FUNCTIONAL_RANGE below); 255=full current

^

Configuration.h:154:34: note: in expansion of macro 'PID_MAX'

#define PID_INTEGRAL_DRIVE_MAX PID_MAX 255 //limit for the integral term

^

temperature.cpp:345:27: note: in expansion of macro 'PID_INTEGRAL_DRIVE_MAX'

temp_iState_max[e] = PID_INTEGRAL_DRIVE_MAX / Ki;

^

temperature.cpp: In function 'void manage_heater()':

Configuration.h:147:26: error: expected ')' before numeric constant

#define PID_MAX BANG_MAX 256 // limits current to nozzle while PID is active (see PID_FUNCTIONAL_RANGE below); 255=full current

^

temperature.cpp:475:28: note: in expansion of macro 'PID_MAX'

if (pid_output > PID_MAX) {

^

Configuration.h:147:26: error: expected ';' before numeric constant

#define PID_MAX BANG_MAX 256 // limits current to nozzle while PID is active (see PID_FUNCTIONAL_RANGE below); 255=full current

^

temperature.cpp:477:24: note: in expansion of macro 'PID_MAX'

pid_output=PID_MAX;

^

temperature.cpp: In function 'void tp_init()':

Configuration.h:147:26: error: expected ';' before numeric constant

#define PID_MAX BANG_MAX 256 // limits current to nozzle while PID is active (see PID_FUNCTIONAL_RANGE below); 255=full current

^

Configuration.h:154:34: note: in expansion of macro 'PID_MAX'

#define PID_INTEGRAL_DRIVE_MAX PID_MAX 255 //limit for the integral term

^

temperature.cpp:813:26: note: in expansion of macro 'PID_INTEGRAL_DRIVE_MAX'

temp_iState_max[e] = PID_INTEGRAL_DRIVE_MAX / Ki;

^

Error compiling.

This report would have more information with
"Show verbose output during compilation"
enabled in File > Preferences.





much appreciated
Joshy

You have two choices.

#define PID_MAX BANG_MAX

or

#define PID_MAX 255

but not

#define PID_MAX BANG_MAX 255

the same for other constants.

---

Triffid Hunter's Calibration Guide

--> X <-- Drill for new Monitor

Most important Gcode.